Skip to content

Nightly rustfmt follow-up #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 4 commits into from
Oct 17, 2025
Merged

Nightly rustfmt follow-up #669

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9272f31
Delete `rust-toolchain.toml` afterall
tnull Oct 17, 2025
e9fe0b3
Disable `overflow_delimited_expr` to ensure stability
tnull Oct 17, 2025
a73d090
Set `rust-version` field in `Cargo.toml`
tnull Oct 17, 2025
2590ee5
Add weekly cronjob running `cargo +nightly fmt`
tnull Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/cron-weekly-rustfmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Nightly rustfmt
Copy link
Copy Markdown
Contributor

@joostjager joostjager Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test-run this job in CI? (temp. schedule to trigger it?)

Copy link
Copy Markdown
Collaborator Author

@tnull tnull Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test-run this job in CI? (temp. schedule to trigger it?)

No, but it's a carbon copy of https://github.com/rust-bitcoin/rust-bitcoin/blob/master/.github/workflows/cron-weekly-rustfmt.yml, which is run weekly over at rust-bitcoin. See for example rust-bitcoin/rust-bitcoin#5120

Copy link
Copy Markdown
Contributor

@joostjager joostjager Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll find out if the weekly works or not...

on:
schedule:
- cron: "0 0 * * 0" # runs weekly on Sunday at 00:00
workflow_dispatch: # allows manual triggering
jobs:
format:
name: Nightly rustfmt
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v5
- uses: dtolnay/rust-toolchain@nightly
with:
components: rustfmt
- name: Run Nightly rustfmt
# Run the formatter and manually remove trailing whitespace.
run: cargo +nightly fmt && git ls-files -- '*.rs' -z | xargs sed -E -i'' -e 's/[[:space:]]+$//'
- name: Get the current date
run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
- name: Create Pull Request
uses: peter-evans/create-pull-request@v7
with:
author: Fmt Bot <bot@example.com>
title: Automated nightly rustfmt (${{ env.date }})
body: |
Automated nightly `rustfmt` changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
commit-message: ${{ env.date }} automated rustfmt nightly
labels: rustfmt
Loading