Update from code changes: refresh preview expiration on start-preview re-run#981
Open
mintlify[bot] wants to merge 1 commit into
Open
Update from code changes: refresh preview expiration on start-preview re-run#981mintlify[bot] wants to merge 1 commit into
mintlify[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
🤖 Documentation Bot✅ All checks passed! No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the new behavior where re-running
lightdash start-previewagainst an existing preview refreshes its expiration.Changes
lightdash start-previewCLI reference explaining that re-runs recomputeexpires_atfrom now, and that omitting--expires-inresets to the upstream project's default.Context
Source PR: lightdash/lightdash#25390 —
feat: update preview expiration when start-preview runs on an existing preview. Previously,--expires-inwas ignored on re-runs and the only way to change expiration was to delete and recreate the preview.