Skip to content

fix: parse transactions from old attribute formats #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgryffindor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: parse transactions from old attribute formats #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions client/src/pages/transaction/details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,17 @@ const methodDetails: {
};

export function details(data: any) {
const detailFn = methodDetails[data.method];
const prettyMethod = PrettyMethods[data.method] || "Unknown";
const method = data.method || data._method;
const detailFn = methodDetails[method];
const prettyMethod = PrettyMethods[method] || "Unknown";

let txn: TableObject = {
Type: (
<Text>
<Tag variant="outline" size="sm">
{prettyMethod}
</Tag>{" "}
(<Code>{data.method}</Code>)
(<Code>{method}</Code>)
</Text>
),
};
Expand All @@ -48,7 +49,7 @@ export function details(data: any) {
txn = { ...txn, ...detailFn(data) };
}

if (data.argument.memo) {
if (data.argument && data.argument.memo) {
txn = {
...txn,
Memo: (
Expand Down
31 changes: 25 additions & 6 deletions client/src/pages/transaction/ledger-send.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,48 @@ import { Link } from "react-router-dom";
import { useFindToken } from "./tokens";

export function useLedgerSend(data: any) {
const token = useFindToken(data.argument.symbol);
let symbol: string = "";
let from: string = "";
let to: string = "";
let amount: any = "";

if (!data.argument) {
if (data._method === "ledger.send") {
symbol = data.symbol;
from = data.from;
to = data.to;
amount = data.amount;
}
} else {
symbol = data.argument.symbol;
from = data.argument.from;
to = data.argument.to;
amount = data.argument.amount;
}

const token = useFindToken(symbol);

return {
From: (
<Code
as={Link}
to={`/addresses/${data.argument.from}`}
to={`/addresses/${from}`}
color="brand.teal.500"
>
{data.argument.from}
{from}
</Code>
),
To: (
<Code
as={Link}
to={`/addresses/${data.argument.to}`}
to={`/addresses/${to}`}
color="brand.teal.500"
>
{data.argument.to}
{to}
</Code>
),
Amount: `${parseFloat((
data.argument.amount /
amount /
10 ** token.precision
).toFixed(token.precision).toLocaleString())} ${token.symbol}`,
};
Expand Down