fix(catalog): exclude uncallable OpenCode Go and Zen models - #2359
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe routed catalog excludes two unsupported OpenCode Go models. The provider registry also removes their thinking-toggle and reasoning-summary configuration. Tests verify the exclusions and confirm three other OpenCode models remain exposed. ChangesOpenCode model compatibility
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Review readiness checklist
3/4 boxes ticked. Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked. |
|
grok-4.6 should be live |
리뷰 · 우선순위 51 / 80설명: 이 PR은 이슈 #2330 이 말한, 고를 수는 있는데 실제로는 호출이 안 되는 OpenCode 모델을 카탈로그에서 빼는 일이다. 지금 CURRENT src/codex/catalog/parsing.ts 라인 149 ROUTED_MODEL_COMPATIBILITY_EXCLUSIONS - hy3만 있던 집합에 mimo 둘과 zen free 한 줄을 더한다. grok-4.6 은 넣지 않는다 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Verification blocker on
|
…rune stale thinking toggle models (lidge-jun#2330)
011 records work-phase 1: four green PRs merged (lidge-jun#2309, lidge-jun#2339, lidge-jun#2335, lidge-jun#2313), lidge-jun#2359 held on a reproduced test failure, a correction to 001 (dev IS protected, by rulesets rather than classic branch protection), and an honest incident record of a hard reset that dropped an unpushed commit and how it was recovered. 090 records work-phase 9, the four PRs that arrived mid-loop. lidge-jun#2361 merged; lidge-jun#2362, lidge-jun#2363 and lidge-jun#2364 left open with their blockers restated. Two of those verdicts rest on falsification rather than diff reading: lidge-jun#2363's tests still pass with its real call site deleted, and lidge-jun#2364's second commit deleted the management validation its first commit added. It also records a CodeRabbit finding that was dismissed as wrong on the evidence.
Records why the four-PR stack was rebuilt on dev rather than merged: only lidge-jun#2301 targeted dev, so dev CI never ran on the runtime diff, and a stacked merge would have reverted coordinator work that landed on src/cli/doctor.ts after the stack was cut (-94/+6 against current dev). lidge-jun#2302 was closed rather than landed. It coerces a missing or non-numeric extraMemorySize into 0 while the watchdog and doctor both type the field optional, so a counter that was never read would surface as jscExtra=0MB inside a series whose only purpose is showing whether native memory grows. Also records the wp1 holdout lidge-jun#2359 landing after the author fixed the exclusion that broke provider-live-models.test.ts:163, and the close of issue lidge-jun#2330 with the reasoning for the two slugs deliberately left exposed.
Closes #2330
Summary
ROUTED_MODEL_COMPATIBILITY_EXCLUSIONS:opencode-go/grok-4.6(injected via augment metadata but absent from authoritative live discovery and rejected with 401)opencode-go/mimo-v2-omni(returned by stale live models, absent from current Go docs, rejected with 400)opencode-go/mimo-v2-pro(returned by stale live models, absent from current Go docs, rejected with 400)opencode-free/deepseek-v4-flash-free(returned by Zen live models, absent from current Zen free docs, rejected with 400)opencode-go/hy3-previewexclusion and retains valid live/preview augmentations (e.g. Ox Alpha Free).Verification
bun test tests/codex-catalog.test.ts(185 pass, 0 fail, coversshouldExposeRoutedModelfor all 4 excluded slugs and control slugs)bun test tests/provider-live-models.test.ts tests/codex-catalog-sync-hardening.test.ts(all pass)bun run typecheck(clean)bun run privacy:scan(passed)git diff --check(clean)Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
Bug Fixes
mimo-v2-omniandmimo-v2-profrom routed compatibility options while continuing to expose supported models.Changes
mimo-v2-omniandmimo-v2-pro.Tests