fix: collapse Google reasoning tiers in model discovery - #2035
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughAntigravity discovery now validates effort tiers, builds complete effort-to-wire mappings, caches them, and attaches them to discovered models. Effort resolution checks discovered mappings before existing fallback rules. Tests cover Gemini Flash and Gemini Pro routing. ChangesAntigravity effort routing
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change consolidates complete Google reasoning-tier listings into a base model while preserving effort-specific routing; the localized behavior change has passing targeted validation, and no actionable merge-blocking risk remains after normal checks. Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request is already Ready for Review. |
Ingwannu
left a comment
There was a problem hiding this comment.
The collapsed-picker direction is correct, but the current head does not yet preserve the effort-routing contract required by #2025. I am requesting changes for two concrete blockers.
-
The new complete-set collapse retains only the first encountered wire ID. With the added fixture, registration stores
gemini-3.7-flash -> gemini-3.7-flash-low; resolving the collapsed row withhighthen returns{ wireModelId: "gemini-3.7-flash-low", thinkingLevel: "high" }. That neither selects the discovered high-tier wire nor follows this module's suffix invariant that a suffixed wire already encodes the effort and should not receive a contradictory thinking level. Preserve the complete base-to-effort wire map (or otherwise select the matching discovered suffix at request time), and add a regression that registers the parsed rows and asserts low/medium/high each route to their corresponding discovered wire. -
Complete labeled Gemini 3.1 Pro sets still do not collapse.
antigravityDisplayModelId()returnsgemini-3.1-pro-low/gemini-3.1-pro-highbefore the existing explicit two-wire mapping runs, so a live payload containinggemini-3.1-pro-lowplusgemini-pro-agentremains two picker rows. Apply complete explicit-set collapse before display-name fallback as well, and cover the labeled low/high payload.
The focused tests and typecheck pass, but the first new test only verifies the picker ID and explicitly accepts the low wire; it needs to prove the subsequent request-routing behavior before this is mergeable.
9be336e to
b999f1d
Compare
|
Thanks for the detailed review and for catching both blockers. Addressed in commit
I also rebased the branch onto the latest |
리뷰 · 우선순위 52 / 80
해결방안: CHANGES_REQUESTED 를 먼저 닫으십시오. 접힌 경로에서 thinkingLevel 을 빼는 것이 envelope 계약과 맞는지 기존 사다리 테스트와 한 줄로 대조하십시오. 맵 miss 의 fallback 을 첫 값 대신 default effort 또는 대표 이 댓글은 grok-bot이 작성했습니다 |
Summary
low/medium/highreasoning tier, such asgemini-3.7-flash-low.gemini-3.7-flash.Verification
npm exec --yes bun -- run typecheckandnpm exec --yes bun -- test tests/google-antigravity-wire.test.ts tests/google-models-listing.test.ts tests/gemini-37-flash-migration.test.ts— typecheck passed; 99 tests passed.npm exec --yes bun -- run typecheck— passed.git diff --check— passed.npm exec --yes bun -- run testwas attempted; unrelated baseline/environment failures remain outside this change (for example Codex shim expectations and missing GUI React dependencies).Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
Bug Fixes
Tests