fix(codex): skip empty native-profile stage sweeps - #1124
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
4a72f2c to
dd20787
Compare
|
Thank you — this is landing as #1134 in the stacked campaign, with your authorship preserved (the commit on that branch is authored by you, cherry-picked, not rewritten). The absence-only framing is what makes this safe on a credential path: the sweep is skipped only when both the stage registry and the staging tree are provably absent, and anything present-or-unreadable still enters the locked fail-closed cleanup. Your regression test pinning both directions is the part that earns the change — a fast path that only proved the happy case would not have been adoptable here. Verified on the stack head: Leaving this PR open for you to close or continue. |
Summary
Closes #1120
Verification
env -u OPENCODEX_API_AUTH_TOKEN taskset -c 0-1 bun test tests/native-profile-stage-lifecycle.test.ts tests/native-profile-drain-server.test.ts tests/codex-auth-context.test.ts— 51 pass, 0 fail.taskset -c 0-1 bun run typecheck— passed.taskset -c 0-1 bun run privacy:scan— passed.git diff --check— passed.Live/Realtime sideband retains main ownership while Direct and non-main Pool continue. The failing case then passed seven consecutive isolated/focused executions.Checklist