Add term definitions for uppsok - #586
Open
niklasl wants to merge 10 commits into
Open
Conversation
niklasl
changed the title
niklasl
marked this pull request as ready for review
April 29, 2026 13:35
niklasl
force-pushed
the
feature/uppsok-terms
branch
from
August 17, 2026 12:04
e80ec2b to
97c93a6
Compare
kaipoykio
requested changes
Aug 20, 2026
kaipoykio
left a comment
kaipoykio
left a comment
There was a problem hiding this comment.
Is it possible to change the setname classification names to corresponding 'Set Spec' identifiers instead (https://uppsok.libris.kb.se/websearchhelp/help_uppsok/metadatamodell.htm#uppsa) ? It would remove one level of translation in the conversion code ;)
Member
Author
|
Makes sense to use those ("set spec") names for the local name parts! (IIRC we made just them up and missed those formal precursors.) |
Member
Author
|
Revised in 8b97957 to use set spec names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define terms for concepts used in Uppsök; specifically: