android: make popup resources package-safe for FOSS builds#692
Open
beeemT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make popup and island overlay resources work with alternate application IDs, including the FOSS build.
Root cause
The overlays constructed
android.resourceURIs with the Play package name (me.kavishdevar.librepods). In the FOSS build, the installed package isme.kavishdevar.librepods.foss, soVideoViewfailed to resolve the raw resource. Its default error dialog was then shown from the service context and crashed withWindowManager.BadTokenException.Changes
VideoViewmedia errors so a media failure cannot open an invalid service-context dialog.Verification
assembleFossReleasesucceeds from a cleanorigin/mainbase.Showing island windowand produced no fatal exception.No existing issue or pull request was found for this exact alternate-application-ID/resource-URI failure. Issue #638 is adjacent but reports a non-responsive Play popup without crash or URI evidence.