Skip to content

android: make popup resources package-safe for FOSS builds#692

Open
beeemT wants to merge 1 commit into
librepods-org:mainfrom
beeemT:fix/foss-popup-resource-uris
Open

android: make popup resources package-safe for FOSS builds#692
beeemT wants to merge 1 commit into
librepods-org:mainfrom
beeemT:fix/foss-popup-resource-uris

Conversation

@beeemT

@beeemT beeemT commented Jul 25, 2026

Copy link
Copy Markdown

Summary

Make popup and island overlay resources work with alternate application IDs, including the FOSS build.

Root cause

The overlays constructed android.resource URIs with the Play package name (me.kavishdevar.librepods). In the FOSS build, the installed package is me.kavishdevar.librepods.foss, so VideoView failed to resolve the raw resource. Its default error dialog was then shown from the service context and crashed with WindowManager.BadTokenException.

Changes

  • Build popup and island video URIs from the runtime application package.
  • Consume and log VideoView media errors so a media failure cannot open an invalid service-context dialog.
  • Match Bluetooth icon resource authorities against the runtime module package in the Xposed hook.

Verification

  • assembleFossRelease succeeds from a clean origin/main base.
  • The signed FOSS APK was installed on a Pixel 10 Pro running Android 17.
  • The island-popup path was exercised after clearing logcat; it logged Showing island window and produced no fatal exception.

No existing issue or pull request was found for this exact alternate-application-ID/resource-URI failure. Issue #638 is adjacent but reports a non-responsive Play popup without crash or URI evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant