Skip to content

Fix broken libp2p implementations link in README.md#708

Open
seetadev wants to merge 2 commits intomasterfrom
seetadev-patch-1
Open

Fix broken libp2p implementations link in README.md#708
seetadev wants to merge 2 commits intomasterfrom
seetadev-patch-1

Conversation

@seetadev
Copy link
Copy Markdown

The hyperlink for libp2p implementations was pointing to a page that no longer exists.

This PR updates the link to the correct and currently active URL for libp2p implementations to ensure accuracy and improve navigation within the specs repository.

No other changes included.

The hyperlink for libp2p implementations was pointing to a page that no longer exists.

This PR updates the link to the correct and currently active URL for libp2p implementations to ensure accuracy and improve navigation within the specs repository.

No other changes included.
@MarcoPolo
Copy link
Copy Markdown
Contributor

You should change this line instead:

specs/README.md

Line 120 in bba73cb

[libp2p_implementations]: https://libp2p.io/implementations
.

But arguably, https://libp2p.io/implementations should redirect to the new link instead.

Update the reference-style link definition for `libp2p_implementations`
in specs/README.md to point to the currently active implementations page.

Previously, the link referenced https://libp2p.io/implementations,
which no longer resolves correctly. This change ensures that all
references using the link label are fixed consistently by updating
the source definition (as suggested in review).
@seetadev
Copy link
Copy Markdown
Author

@MarcoPolo: Thanks for your feedback and pointers. Appreciate it.

I’ve updated the reference at the suggested line so it correctly maps to the current implementations page for now.

Completely agree that having https://libp2p.io/implementations redirect to the new location is the better fix. We’ll coordinate on the website side to get that in place. Will open a new PR and redirect to https://libp2p.io/implementations once that is done.

Appreciate the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants