cmake: list-separate frameworks in FindMETAL.cmake#811
Open
slitvinov wants to merge 1 commit intolibocca:mainfrom
Open
cmake: list-separate frameworks in FindMETAL.cmake#811slitvinov wants to merge 1 commit intolibocca:mainfrom
slitvinov wants to merge 1 commit intolibocca:mainfrom
Conversation
INTERFACE_LINK_LIBRARIES expects a CMake list (semicolon-separated).
The space-separated form makes CMake treat the three framework paths
as a single one, and the linker fails:
ld: warning: search path '/.../Metal.framework /.../CoreServices.framework /.../Frameworks' not found
Undefined symbols for architecture arm64: "_MTLCopyAllDevices"
One-character fix on macOS arm64 with a recent Xcode SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTERFACE_LINK_LIBRARIESexpects a CMake list (semicolon-separated). The space-separated form incmake/FindMETAL.cmake:24makes CMake treat the three framework paths as a single one. On macOS arm64 with a recent Xcode SDK the linker fails:One-character fix: replace the spaces with semicolons.