Merged
Conversation
7bf66ef to
07e439f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors CMake build configuration across the OCCA project. It splits the C and Fortran APIs into separate shared libraries (c_api and fortran_api), reformats all target_sources() and target_link_libraries() calls to use multi-line format for improved readability, and updates linking dependencies throughout the codebase.
Key changes:
- Created separate
c_apiandfortran_apishared libraries - Reformatted all CMake function calls to use consistent multi-line style
- Updated all examples and tests to link against the new library targets
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Reorganized RPATH settings, reformatted library configuration, moved Clang transpiler setup, updated install targets for new libraries |
| src/c/CMakeLists.txt | Created new c_api shared library, reformatted source list |
| src/fortran/CMakeLists.txt | Created new fortran_api shared library, changed from adding sources to libocca to standalone library |
| src/c/experimental/CMakeLists.txt | Updated to add sources to c_api instead of libocca |
| tests/CMakeLists.txt | Added linking to c_api and conditionally to fortran_api, reformatted function calls |
| examples/CMakeLists.txt | Added linking to new API libraries with conditional Fortran support |
| src/loops/CMakeLists.txt | Added target_include_directories configuration |
| src/functional/CMakeLists.txt | Reformatted target_sources call |
| All other src/**/CMakeLists.txt | Consistently reformatted target_sources calls to multi-line format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
07e439f to
b3f93e7
Compare
Collaborator
Author
|
All the tests pass on Polaris with the following commands: module load gcc-native
module use /soft/modulefiles/
module load spack-pe-base cmake
cmake --workflow --preset gnu-default |
829a3a0 to
cd96fd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.