fix: disable GIL for free-threaded builds#1430
Merged
jdavid merged 1 commit intolibgit2:masterfrom Oct 13, 2025
Merged
Conversation
Contributor
Author
|
I have another branch ( |
|
Thanks for following up on this!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This properly disables the GIL for free threaded python builds. Thanks to advice from @ngoldbaum
This patch simply gets pygit2 ready for use with Python 3.14t without warnings/errors.
All tests pass with Python v3.14t and
python -c "import pygit2"completes without warnings.I haven't done a through code review for spots (in
src/*) where thread safety might be a concern.My impression is that
_pygit2(when appropriate) invokes_libgit2(which is compiled withcffi). So, I'm guessing most thread safety concerns are delegated tocffi.