Skip to content

Add support for wolfssl#1293

Open
lapinozz wants to merge 1 commit intolibcpr:masterfrom
CyrexWare:wolfssl
Open

Add support for wolfssl#1293
lapinozz wants to merge 1 commit intolibcpr:masterfrom
CyrexWare:wolfssl

Conversation

@lapinozz
Copy link

Added support for wolfssl, which already has a OpenSSL api layer

The advantage of wolfssl is that it doesn't have extra dependency that have to be installed, such that you can set it up with just FetchContent

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lapinozz thanks for adding this. Only one minor change and could you please add a CI test for it?

if(WOLFSSL_FOUND)
set(SSL_BACKEND_USED "WolfSSL")
else()
message(FATAL_ERROR "No valid SSL backend found! Please install OpenSSL, Mbed TLS or disable SSL by setting CPR_ENABLE_SSL to OFF.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message(FATAL_ERROR "No valid SSL backend found! Please install OpenSSL, Mbed TLS or disable SSL by setting CPR_ENABLE_SSL to OFF.")
message(FATAL_ERROR "No valid SSL backend found! Please install OpenSSL, Mbed TLS, WolfSSL or disable SSL by setting CPR_ENABLE_SSL to OFF.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants