Conversation
405d702 to
6dc4338
Compare
COM8
left a comment
There was a problem hiding this comment.
@simue perfect. Thanks!
Could you please add a bit of in line documentation for your two new functions like I'm doing it here:
#1168
Also please add a few sentences of documentation about your feature here:
https://github.com/libcpr/docs
|
Now, that I am trying to document this, I am hesitating with the resulting interface: Do you know if people are actually using session to send the same payload multiple times? Because if they are not, I´d rather call RemoveContent() after every request that carries a body. |
|
MultiperformPerformTests.MultiperformMixedMethodsPerformTest seems to be flaky - did you see it have issues before? |
Ah, yes :D This always has been a bit of a discussion point but we decided to go this way. Even if it's the more intuitive way that in reality might almost always require more code to clear the content before reusing. |
Yes, especially on macOS. This is a limitation of the mock server we are using for our tests. |
COM8
left a comment
There was a problem hiding this comment.
Thanks! 2 Minor things regarding your comments and the we are ready to go!
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
Co-authored-by: Fabian Sauter <sauter.fabian@mailbox.org>
|
Approved, merged and is now part of the 1.11.x branch. I will try to make a new release over the next weekend. |
|
thank you very much for the good collaboration! |
Closes #1171