Skip to content

Workaround nearbyint() for Kokkos SYCL backend #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NamjaeChoi wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −0
Draft

Workaround nearbyint() for Kokkos SYCL backend #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/utilities/include/metaphysicl/metaphysicl_math.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@ namespace math {
} \
}

#define METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY_STD_ALIAS(ALIAS, NAME) \
namespace detail { \
template <class X> METAPHYSICL_INLINE auto unqualified_##ALIAS(const X &x) { \
if constexpr (std::is_arithmetic_v<X>) \
return std::NAME(x); \
else { \
using std::NAME; \
return NAME(x); \
} \
} \
}

#ifdef METAPHYSICL_KOKKOS_COMPILATION
#define METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY(NAME) \
namespace detail { \
Expand All @@ -45,9 +57,22 @@ namespace math {
} \
} \
}
#define METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY_ALIAS(ALIAS, NAME) \
namespace detail { \
template <class X> METAPHYSICL_INLINE auto unqualified_##ALIAS(const X &x) { \
if constexpr (std::is_arithmetic_v<X>) \
return Kokkos::NAME(x); \
else { \
using Kokkos::NAME; \
return NAME(x); \
} \
} \
}
#else
#define METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY(NAME) \
METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY_STD(NAME)
#define METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY_ALIAS(ALIAS, NAME) \
METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY_STD_ALIAS(ALIAS, NAME)
#endif

#ifdef METAPHYSICL_KOKKOS_COMPILATION
Expand Down Expand Up @@ -90,6 +115,12 @@ namespace math {
return detail::unqualified_##NAME(x); \
}

#define METAPHYSICL_MATH_UNARY_ALIAS(ALIAS, NAME) \
METAPHYSICL_MATH_DETAIL_UNQUALIFIED_UNARY_ALIAS(ALIAS, NAME) \
template <class X> METAPHYSICL_INLINE auto ALIAS(const X &x) { \
return detail::unqualified_##ALIAS(x); \
}

// Macro to call when there is a backing math function in c
#define METAPHYSICL_MATH_BINARY(NAME) \
METAPHYSICL_MATH_DETAIL_UNQUALIFIED_BINARY(NAME) \
Expand Down Expand Up @@ -129,7 +160,11 @@ METAPHYSICL_MATH_UNARY(erf)
METAPHYSICL_MATH_UNARY(erfc)
METAPHYSICL_MATH_UNARY(trunc)
METAPHYSICL_MATH_UNARY(round)
#if defined(METAPHYSICL_KOKKOS_COMPILATION) && defined(KOKKOS_ENABLE_SYCL)
METAPHYSICL_MATH_UNARY_ALIAS(nearbyint, rint)
#else
METAPHYSICL_MATH_UNARY(nearbyint)
#endif
METAPHYSICL_MATH_UNARY_STD(rint)
METAPHYSICL_MATH_UNARY(real)
METAPHYSICL_MATH_UNARY(imag)
Expand Down