pq: simple support for named parameters#846
Closed
jeromedoucet wants to merge 2 commits intolib:masterfrom
Closed
Conversation
what: Add named parameters support for "conn". It works basically like ordinals parameters, but with an alphabetical label prefixed with ":" Example: Select $1, $2, $1; may become Select :firstName, :lastName, :firstName Why: SQL queries may be difficult to maintain, especially when the complexity is growing. Ordinal parameters are great, but may not be meaningfull for the one who is trying to understand the query. The goal here is not to have something full featured and complex : pq is "just" a driver, but having a thin layer, simple to maintain, that will fit 90% of the needs. Limitations: Its simplicity means that there is many limitations : First of all, using mixed types of parameters is not allowed. Man can not use ordinal parameters and named parameters is the same query. Refs lib#534
Add explicit cast for some postgres version. Refs lib#534
|
any blocker? |
Collaborator
|
I'm quite hesitant to use a regexp-based solution for this, as per my comment in #534 (comment) While this at least avoids the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what:
Add named parameters support for "conn". It works basically like ordinals
parameters, but with an alphabetical label prefixed with ":"
Example:
Select $1, $2, $1; may become Select :firstName, :lastName, :firstName
Why:
SQL queries may be difficult to maintain, especially when the complexity
is growing. Ordinal parameters are great, but may not be meaningfull for
the one who is trying to understand the query.
The goal here is not to have something full featured and complex : pq is
"just" a driver, but having a thin layer, simple to maintain, that will
fit 90% of the needs.
Limitations:
Its simplicity means that there is many limitations :
First of all, using mixed types of parameters is not
allowed. Man can not use ordinal parameters and named
parameters is the same query.
Refs #534