Allow to change (or disable) the default driver name for registration#1160
Closed
demoManito wants to merge 2 commits intolib:masterfrom
Closed
Allow to change (or disable) the default driver name for registration#1160demoManito wants to merge 2 commits intolib:masterfrom
demoManito wants to merge 2 commits intolib:masterfrom
Conversation
Collaborator
|
Seems okay at a glance, but what is the use case for this? It's not mentioned in the PR, or in the PR for the MySQL driver (go-sql-driver/mysql#1499). |
Collaborator
|
I'm closing this for now as it's unclear what problem this addresses or why we want to do this, so it's also not clear if this is the best way to address it. Can reopen if more details are added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A link variable now allows to change or disable the name of the driver that is automatically registered with
database/sql.This allows users to give the
postgresname to anotherdatabase/sqldriver.The implementation is the same as in: https://github.com/go-sql-driver/mysql driver. See https://github.com/go-sql-driver/mysql/blob/af8d7931954ec21a96df9610a99c09c2887f2ee7/driver.go#L92
Usage
Change the driver name to
custom:Disable the automatic driver registration (set
driverNameto an empty string):In the same way, a variable overridable at link time is also provided to override the driver name used in the test suite. This allows to run our test suite on another driver.
driverNameis propagated todriverNameTestunlessdriverNameTestis explicitely defined.