Patch for saving Table OID and Attribute Number#1117
Closed
calledit wants to merge 3 commits intolib:masterfrom
Closed
Patch for saving Table OID and Attribute Number#1117calledit wants to merge 3 commits intolib:masterfrom
calledit wants to merge 3 commits intolib:masterfrom
Conversation
rafiss
requested changes
Apr 14, 2023
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
thanks for the contribution. could you please add a test that confirms it works as expected?
Collaborator
|
As near as I can tell these fields are never actually exposed? So I'm not sure how you would go about actually using them? I guess that's also why a test was never added? It's not really possible to expose this through database/sql. For better or worse, it doesn't really have any good facilities for exposing very database-specific things such as this. Let me know if I'm wrong, but as far as I can tell, this is just not possible with a database/sql compatible driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When columns are renamed in sql queries, tracking the original table and column is not possible in the current implementation.
Example:
In this query the original table will not be accessible, despite postgres acctually returning that information.
This patch adds two propertys to the fieldDesc struct and code to parse those fields from the postgres response.
Originally mentioned in #363