proof: add shl expression helper bridges#2187
Open
Th0rgal wants to merge 1 commit into
Open
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_66d3df40-7758-4d26-9c13-2d54a4967d78) |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
Status: success · Mode: medium-lean · 0 finding(s) · 2 files · 518354 tokens · 39 tool calls
No comments generated. Looks good to me.
OCR pilot metrics
- Routing: medium-lean (router-v8)
- Changed files: 2 supported / 2 total; Lean 2, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 271 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status success; comments 0; files 2; tokens 518354; tool calls 39; warnings 0; duration 511s
- Largest changed files: Compiler/Proofs/HelperStepProofs.lean (+260/-0), PrintAxioms.lean (+10/-1)
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expr.shlsource/Yul value and builtin agreement lemma for EVM shift-left semanticsExpr.shlExpr.shlPrintAxioms.leanValidation
lean-slot lake build Compiler.Proofs.HelperStepProofspython3 scripts/check_proof_length.pypython3 scripts/generate_print_axioms.pypython3 scripts/generate_print_axioms.py --checkgit diff --checkrg -n "\\b(sorry|admit|axiom)\\b|set_option\\s+autoImplicit\\s+true" Compiler/Proofs/HelperStepProofs.lean(no matches)Notes
codex/2080-expr-helper-bitnot-threaded.PrintAxioms.leanreports5765 theorems/lemmas (4005 public, 1760 private, 0 sorry'd).Note
Low Risk
Proof-only additions in HelperStepProofs with no runtime or compiler behavior changes; axiom inventory update is mechanical.
Overview
Extends the compiler correctness proof chain for
Expr.shlusing the same pattern as recent bitwise helper work (bitNot,bitXor).Adds
exprShlValueand lemmas tying it toUint256.shl, EVM modulus bounds, and the concrete builtin rule (shift < 256 vs zero). Proves compile/source/builtin alignment (compileExprWithInternals_shl_of_children,evalExprWithHelpers_shl_of_values,evalBuiltinCallWithEvmYulLeanContext_shl_of_values) and left/right-threadedExprInternalHelperCompositionalContextResult/PostStateResultbridges so helper-step induction can treatshllike other binary builtins.PrintAxioms.leanis regenerated to register the nine new public lemmas (theorem count 5765, up by 9).Reviewed by Cursor Bugbot for commit 0935cee. Bugbot is set up for automated code reviews on this repo. Configure here.