proof: add bitXor expression helper bridges#2185
Open
Th0rgal wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_602702c0-fdc8-453c-9f35-68e18524b9db) |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
Status: success · Mode: medium-lean · 0 finding(s) · 2 files · 212481 tokens · 16 tool calls
No comments generated. Looks good to me.
OCR pilot metrics
- Routing: medium-lean (router-v8)
- Changed files: 2 supported / 2 total; Lean 2, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 248 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status success; comments 0; files 2; tokens 212481; tool calls 16; warnings 0; duration 223s
- Largest changed files: Compiler/Proofs/HelperStepProofs.lean (+237/-0), PrintAxioms.lean (+10/-1)
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expr.bitXor, including builtin agreement and source helper evaluationExpr.bitXorhelper payloadsPrintAxioms.leanwith the new bitXor bridge declarations; total still reports 0 sorryValidation
lean-slot lake build Compiler.Proofs.HelperStepProofspython3 scripts/check_proof_length.pypython3 scripts/generate_print_axioms.pypython3 scripts/generate_print_axioms.py --checkgit diff --checkrg -n "\\b(sorry|admit|axiom)\\b|set_option\\s+autoImplicit\\s+true" Compiler/Proofs/HelperStepProofs.lean(no matches)Note
Low Risk
Proof-only additions mirroring established bitOr patterns; no runtime or compiler behavior changes.
Overview
Adds formal proof infrastructure for
Expr.bitXorinHelperStepProofs.lean, following the same pattern as the existingbitOrbridges.Introduces
exprBitXorValue(Uint256 xor modulo EVM) with bounds and agreement withNat.xorand the Yulxorbuiltin. New lemmas tie compilation toYulExpr.call "xor", source helper evaluation, and builtin IR evaluation to that shared value.Adds right- and left-threaded compositional context/poststate theorems so helper-aware source/IR steps for bitwise xor compose through child proofs via the shared binary-builtin threading lemmas.
PrintAxioms.leanis regenerated to list the nine new theorems (theorem count 5738 → 5747).Reviewed by Cursor Bugbot for commit 5d9aabc. Bugbot is set up for automated code reviews on this repo. Configure here.