proof: add mod expression helper bridges#2182
Open
Th0rgal wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_dc53039f-44d6-46df-9287-40a2dd6c2eee) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
Status: success · Mode: medium-lean · 0 finding(s) · 2 files · 79103 tokens · 12 tool calls
No comments generated. Looks good to me.
OCR pilot metrics
- Routing: medium-lean (router-v8)
- Changed files: 2 supported / 2 total; Lean 2, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 255 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status success; comments 0; files 2; tokens 79103; tool calls 12; warnings 0; duration 163s
- Largest changed files: Compiler/Proofs/HelperStepProofs.lean (+244/-0), PrintAxioms.lean (+10/-1)
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expr.mod, including builtin agreement and source helper evaluationExpr.modhelper payloadsPrintAxioms.leanwith the new mod bridge declarations; total still reports 0 sorryValidation
lean-slot lake build Compiler.Proofs.HelperStepProofspython3 scripts/check_proof_length.pypython3 scripts/generate_print_axioms.pypython3 scripts/generate_print_axioms.py --checkgit diff --checkrg -n "\\b(sorry|admit|axiom)\\b|set_option\\s+autoImplicit\\s+true" Compiler/Proofs/HelperStepProofs.lean(no matches)Note
Low Risk
Lean proof-only additions following the established div pattern; no executable compiler or security-sensitive runtime behavior changes.
Overview
Adds formal proof support for
Expr.modin the helper-step compositional pipeline, parallel to the existingExpr.divbridges.Introduces
exprModValuewith bounds, builtin agreement (uint256_mod_val_eq), and lemmas tying compilation (YulExpr.call "mod"), source evaluation (evalExprWithHelpers), and Yul builtin evaluation to that value. Four threaded theorems lift a proven left or right child intoExprInternalHelperCompositionalContextResult/PostStateResultforExpr.mod, reusing the shared binary builtin helpers.PrintAxioms.leanis regenerated to list the nine new declarations (theorem count 5711 → 5720).Reviewed by Cursor Bugbot for commit 28c9524. Bugbot is set up for automated code reviews on this repo. Configure here.