feat: added timeout for keep alive connections#67
Open
lev2p1 wants to merge 1 commit into
Open
Conversation
Owner
Author
|
@NikSimDev test it |
NikSimDev
requested changes
Jun 19, 2026
NikSimDev
left a comment
NikSimDev
left a comment
Collaborator
There was a problem hiding this comment.
The added timeout has a minor impact on performance in normal scenarios, but it can cause problems under high loads.
Problem areas:
- A timer is created for each connection, even for short ones
- async_wait creates an additional operation in the io_context
- At high request rates (~1000+ RPS), the overhead becomes noticeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issues:
Type of Change:
Description:
Added a timeout for keep-alive connections. Testing and feedback on these new features are required.
Testing:
The code compiles and the connection is terminated correctly.
Checklist: