Ceremony: generate serials with a prefix to guarantee length#8899
Open
aarongable wants to merge 1 commit into
Open
Ceremony: generate serials with a prefix to guarantee length#8899aarongable wants to merge 1 commit into
aarongable wants to merge 1 commit into
Conversation
aarongable
force-pushed
the
ca-serial-prefix
branch
from
July 23, 2026 23:55
7ad15c3 to
ce88d82
Compare
aarongable
marked this pull request as ready for review
July 24, 2026 00:01
ezekiel
approved these changes
Jul 24, 2026
jsha
approved these changes
Jul 24, 2026
jsha
left a comment
jsha
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, with the caveat that we're blocked on CP/CPS update.
| // We want 128 bits of random number, plus a prefix to ensure that the serial is | ||
| // never shorter than that, even if the CSPRNG generates lots of leading zeroes. | ||
| const randBits = 128 | ||
| serial := make([]byte, randBits/8+1) |
Contributor
There was a problem hiding this comment.
We need to update the CP/CPS to say the new number of bits (or encoded bytes) for our issuing certificate profiles before we land this. Resolve this conversation once we've done that, then we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This borrows code very similar to that used in ca.go:generateSerialNumber to ensure that our CA serials always obviously contain the desired number of bytes, even if the random number generator gives us lots of leading zeroes that a DER encoding would elide.