Open
Conversation
Since the RA always starts unhealthy (it needs to load overrides), this allows it to become healthy sooner. This speeds up integration test startup by about 20s, because we start four instances of RA, and they were all waiting on their second internal health check before they could become healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the RA always starts unhealthy (it needs to load overrides), this allows it to become healthy sooner.
This speeds up integration test startup by about 20s, because we start four instances of RA, and they were all waiting on their second internal health check before they could become healthy.
Note that our
health-checkerbinary (used fromstartservers.py) checks health every 100ms, but no requests are actually sent over the wire because the server side has not sent the client a streaming reply to theHealthClient.Watch()RPC. We do have the option of plumbing things up so that RA can callserverBuilder.healthSrv.SetServingStatus()as soon as its overrides are loaded, which would speed things up a bit more, but this seems good enough for now.