ra: improve error message about IP address support#8592
Merged
beautifulentropy merged 2 commits intomainfrom Feb 4, 2026
Merged
ra: improve error message about IP address support#8592beautifulentropy merged 2 commits intomainfrom
beautifulentropy merged 2 commits intomainfrom
Conversation
Old: Profile "" does not permit ip type identifiers New: Default profile does not permit IP address identifiers. See available profiles at https://letsencrypt.org/docs/profiles/.
aarongable
previously approved these changes
Jan 23, 2026
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
Looks like none of the tests cover the "Default profile..." case.
beautifulentropy
approved these changes
Jan 27, 2026
aarongable
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old:
Profile "" does not permit ip type identifiers
New:
Default profile does not permit IP address identifiers. See available profiles at https://letsencrypt.org/docs/profiles/.