fix(settings): pass through deferLoading and other MCP config fields in mergeMcpServers - #309
Open
raymondginger2018-sudo wants to merge 1 commit into
Conversation
…pServers mergeMcpServers only kept command/args/env and dropped deferLoading, connectTimeoutMs, required, enabledTools, disabledTools, url, headers when merging user + project settings. This made deferLoading:true in settings.json ineffective at startup. - Merge all McpServerConfig fields with project-wins/user-fallback precedence (same as command/args), booleans use ?? so explicit false is preserved - Add test: resolveSettingsSources preserves deferLoading and extra MCP fields (project wins, user falls back)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config-layer half of deferLoading support. mergeMcpServers dropped all fields except command/args/env; now passes through deferLoading, connectTimeoutMs, required, enabledTools, disabledTools, url, headers (project wins / user falls back). Tests: 298 pass / 0 fail. Engine-side support is in #298.