Add support for dataframe and arrow table in add_entities#907
Merged
mdekstrand merged 6 commits intolenskit:mainfrom Mar 28, 2026
Merged
Add support for dataframe and arrow table in add_entities#907mdekstrand merged 6 commits intolenskit:mainfrom
mdekstrand merged 6 commits intolenskit:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 223 223
Lines 15476 15499 +23
=======================================
+ Hits 13881 13902 +21
- Misses 1595 1597 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdekstrand
requested changes
Oct 27, 2025
Member
mdekstrand
left a comment
There was a problem hiding this comment.
Good work! There are some subtle edge cases for different Pandas index layouts we need to handle, and documentation to add, but otherwise it looks sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows client to call add_entities with either dataframe or arrow table without having to call individual add_attributes for all of the data columns.