Lock some stuff behind #if [condition]#1
Merged
lemz1 merged 1 commit intolemz1:feature/new-polymod-script-class-implementationfrom Mar 12, 2025
Merged
Conversation
KoloInDaCrib
force-pushed
the
lemz-pr/lock-a-thing-lol
branch
from
b03a124 to
97aae9f
Compare
KoloInDaCrib
changed the title
#if lime#if [condition]
there's some compilation errors in some classes if a library isn't available and polymod is the only thing that's in a project
KoloInDaCrib
force-pushed
the
lemz-pr/lock-a-thing-lol
branch
from
97aae9f to
728fb97
Compare
Owner
i'd say we keep them out of this pr, since this pr is already extremely big. although, i am going to mention this in the pr description, in case Eric says it's okay to add new features into this pr like your getters and setters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imo I think this should be locked behind a
#if limecuz lime's not a required dependency for polymod lolthe same principle applies to most of the classes inside
hscript/_internalfolder since hscript is not a required dependencyfor ur pr
also if you think some of my polymod prs (like the support for get and set functions) would be fitting inside yours lemme know