fix(server): close connection when not allowed by --allow#53
Open
nemith wants to merge 1 commit intolemonade-command:masterfrom
Open
fix(server): close connection when not allowed by --allow#53nemith wants to merge 1 commit intolemonade-command:masterfrom
nemith wants to merge 1 commit intolemonade-command:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I explicitly set my allow list to
127.0.0.1/32and was surprised that with my server settings like that connections from the client would freeze indefinitely with no errors in the logs.Digging into the problem showed that when an IP is denied it just continues for the next connection leaving the old connection to just leak and never close.
This adds explicit close. It may be better to have handle function that make sure close is in a defer to prevent future issues but that is more refactoring here. Also adds some logging when a connection is denied so that it isn't silent.