fix: harden DrugRecommendationOMOP history, codes, and tests - #1
Closed
AxelNoun wants to merge 2 commits into
Closed
fix: harden DrugRecommendationOMOP history, codes, and tests#1AxelNoun wants to merge 2 commits into
AxelNoun wants to merge 2 commits into
Conversation
Drop empty/OMOP-0 concept ids, copy nested history lists so samples do not alias, and replace the mock leakage test with a discriminating set_task fixture. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep TemporaryDirectory/close() failures visible on Linux CI, and document why new task re-exports use the redundant X as X form. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drugleak), not a competing PR againstmaster.set_taskfixture.TemporaryDirectory/close()cleanup errors only on Windows so Linux CI still surfaces real failures; keep the redundantX as Xre-export form documented.Test plan
drugleaktests/core/test_drug_recommendation_omop.py