[19.0][OU-FIX] base: strip 19.0 RNG-removed search-view attrs#19
Draft
dnplkndll wants to merge 1 commit into
Draft
[19.0][OU-FIX] base: strip 19.0 RNG-removed search-view attrs#19dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
dnplkndll
force-pushed
the
19.0-fix-base-strip-search-view-removed-attrs
branch
from
1d36d6a to
9f74fb5
Compare
19.0's RelaxNG schema removes `expand=` on <group>/<field> and `string="Group By"` on <group> in <search> views. Stored 18.0 arch_db carrying these attrs fails _check_xml on module upgrade, leaving the view unrenderable and breaking xml_id lookups downstream (e.g. website_forum.forum_post_view_search). Strip the attrs in pre-migration via jsonb_each + regex_replace on the multi-lang arch_db; module updates regenerate clean blobs from the new source XML.
dnplkndll
force-pushed
the
19.0-fix-base-strip-search-view-removed-attrs
branch
from
9f74fb5 to
7b2fc99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip 19.0 RNG-removed attributes from stored 18.0 search-view
arch_db:expand=on<group>(groupby) and<field>(searchpanel)string="Group By"on<group>(label is implicit in 19.0)Without this, the first module update touching an affected view crashes:
Non-mechanical adaptations
arch_dbis jsonb (multi-lang) since 17.0 — iterate per language key viajsonb_each+jsonb_object_agg, regex on the unescaped value (#>> '{}'), rebuild.type='search'.<list expand=…>is still valid in 19.0 — broader scoping would brick it.oca_18_enriched): 181 affected views → 0; downstreamforum_post_view_searchcliff cleared.Test fixture in
base/tests/seeds an 18.0 view carrying both attr shapes and asserts post-migration removal.