Skip to content

optimize: avoid pcall when validating the Connection response header #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriemer merged 1 commit into from
Jun 11, 2026
Merged

optimize: avoid pcall when validating the Connection response header #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/resty/http.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,15 +798,16 @@ function _M.read_response(self, params)
end

-- keepalive is true by default. Determine if this is correct or not.
local ok, connection = pcall(str_lower, res_headers["Connection"])
if ok then
if (version == 1.1 and str_find(connection, "close", 1, true)) or
(version == 1.0 and not str_find(connection, "keep-alive", 1, true)) then
local connection = res_headers["Connection"]
if type(connection) ~= "string" then
-- no connection header (or duplicated as a table)
if version == 1.0 then
self.keepalive = false
end
else
-- no connection header
if version == 1.0 then
connection = str_lower(connection)
if (version == 1.1 and str_find(connection, "close", 1, true)) or
(version == 1.0 and not str_find(connection, "keep-alive", 1, true)) then
self.keepalive = false
end
end
Expand Down
Loading