Skip to content

fix(settings): fix some links in the privacy modal#5762

Merged
marcellamaki merged 3 commits intolearningequality:unstablefrom
habibayman:fix/5755
Mar 17, 2026
Merged

fix(settings): fix some links in the privacy modal#5762
marcellamaki merged 3 commits intolearningequality:unstablefrom
habibayman:fix/5755

Conversation

@habibayman
Copy link
Member

@habibayman habibayman commented Mar 16, 2026

Summary

Followed Peter's report and replaced the links that were caught broken in the privacy modal and are documented in a screen recording in his issue description here.

  1. http://localhost:8080/en/channels/#/my-channels?showPolicy=community_standards
    ->
    http://localhost:8080/en/channels/#/my-channels?showPolicy=terms_of_service

  2. https://learningequality.org/cookies/
    ->
    https://learningequality.org/cookie-policy/


References


Reviewer guidance

Navigate to http://localhost:8080/en/channels/#/my-channels?showPolicy=privacy_policy and validate the links are working fine.

I am surprised these changes didn't cause any unit tests to fail though! I think we should write some to verify that

@learning-equality-bot
Copy link

👋 Thanks for contributing!

We will assign a reviewer within the next two weeks. In the meantime, please ensure that:

  • You ran pre-commit locally
  • All issue requirements are satisfied
  • The contribution is aligned with our Contributing guidelines. Pay extra attention to Using generative AI. Pull requests that don't follow the guidelines will be closed.

We'll be in touch! 😊

@marcellamaki marcellamaki self-assigned this Mar 16, 2026
@marcellamaki marcellamaki self-requested a review March 16, 2026 23:42
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @habibayman ! manual QA confirms ✅

@marcellamaki marcellamaki merged commit 23bafd7 into learningequality:unstable Mar 17, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy policy and Terms of service - Broken links

2 participants