fix(settings): fix some links in the privacy modal#5762
Merged
marcellamaki merged 3 commits intolearningequality:unstablefrom Mar 17, 2026
Merged
fix(settings): fix some links in the privacy modal#5762marcellamaki merged 3 commits intolearningequality:unstablefrom
marcellamaki merged 3 commits intolearningequality:unstablefrom
Conversation
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
marcellamaki
approved these changes
Mar 17, 2026
Member
marcellamaki
left a comment
There was a problem hiding this comment.
thanks @habibayman ! manual QA confirms ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followed Peter's report and replaced the links that were caught broken in the privacy modal and are documented in a screen recording in his issue description here.
http://localhost:8080/en/channels/#/my-channels?showPolicy=community_standards->
http://localhost:8080/en/channels/#/my-channels?showPolicy=terms_of_servicehttps://learningequality.org/cookies/->
https://learningequality.org/cookie-policy/References
Reviewer guidance
Navigate to
http://localhost:8080/en/channels/#/my-channels?showPolicy=privacy_policyand validate the links are working fine.I am surprised these changes didn't cause any unit tests to fail though! I think we should write some to verify that