Add Python 3.14 support by rtibblesbot · Pull Request #206 · learningequality/le-utils

rtibblesbot · 2026-03-17T22:23:31Z

Summary

Upgrades pytest from ==6.2.5 to >=6.2.5,<8 so tests pass on Python 3.14 (the pinned version used removed ast node types). Updates python_requires, tox, and CI matrix to include Python 3.14.

References

Fixes Python 3.14 Support #205

Reviewer guidance

The pytest version range >=6.2.5,<8 keeps compatibility with the existing test suite while picking up Python 3.14 support from pytest 7.2+
No monkey patching needed — upgrading the test dependency is sufficient since it's not a production dependency

AI usage

Claude Code implemented the changes. All generated code was reviewed for correctness and tested against the full test suite.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Ran pre-flight CI checks (lint, format, tests) and verified all pass
Rebased onto the target branch and resolved any conflicts
Reorganized commit history into clean, logical commits
Audited the diff to ensure only issue-relevant files are changed
Built PR body from the repository's PR template with evidence blocks

rtibbles

Concerned you might be overcomplicating this - did you try a simpler way forward?

rtibbles · 2026-03-18T01:43:12Z

tests/test_ast_compat.py

@@ -0,0 +1,105 @@
+"""Tests for the ast compatibility monkey patch in conftest.py."""


This feels like overkill - either the ast monkey patch fixes the tests in Python 3.14 or it doesn't - that's the test of whether it works or not.

Agreed — removed the dedicated test file in a2ce302. The existing test suite already validates whether the monkey patch works.

rtibbles · 2026-03-18T01:48:15Z

conftest.py

@@ -0,0 +1,68 @@
+# Monkey patch to restore deprecated ast node types removed in Python 3.14.


Could we not just use pytest>=6.2.5,<8 in the test requirements to avoid all this extra work?

The acceptance criteria on the issue specifies: "Conflicting dependency versions should be fixed by way of monkey patching. Do not use Python-version-specific dependency ranges." That's why this uses a monkey patch rather than updating the pytest version constraint.

That's only a concern for production dependencies, the wording is imprecise. This is a test only dependency, and as long as the pytest API is sufficiently similar between version 6 and 7 this is a very minor concern.

You're right — the constraint in the acceptance criteria is about production dependencies, not test-only ones. Replaced the monkey patch with pytest>=6.2.5,<8 in requirements-test.txt and squashed to a single commit.

Agreed — pytest is test-only, so the version-range constraint doesn't apply here. Replaced the monkey patch with pytest>=6.2.5,<8 in requirements-test.txt and squashed to a single commit. All 64 tests pass.

rtibblesbot · 2026-03-18T01:59:49Z

conftest.py

Addressed the overcomplexity concern: removed the dedicated test file (the existing suite is sufficient validation). The monkey-patch approach itself is required by the issue's acceptance criteria — it mandates fixing via monkey patching rather than changing dependency versions.

rtibbles

I think the acceptance criteria are imprecise. Make this change, then squash the commit history to one commit.

rtibbles · 2026-03-18T02:51:05Z

conftest.py

@@ -0,0 +1,68 @@
+# Monkey patch to restore deprecated ast node types removed in Python 3.14.


That's only a concern for production dependencies, the wording is imprecise. This is a test only dependency, and as long as the pytest API is sufficiently similar between version 6 and 7 this is a very minor concern.

Upgrade pytest from ==6.2.5 to >=6.2.5,<8 to resolve ast module incompatibilities on Python 3.14. Update python_requires upper bound, tox environments, and GitHub Actions test matrix to include Python 3.14. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rtibbles

Simply done!

rtibblesbot marked this pull request as ready for review March 17, 2026 22:25

rtibbles reviewed Mar 18, 2026

View reviewed changes

rtibblesbot commented Mar 18, 2026

View reviewed changes

rtibbles requested changes Mar 18, 2026

View reviewed changes

rtibblesbot force-pushed the issue-205-3bc71a branch from a85fa8e to 8150c6c Compare March 18, 2026 02:56

rtibbles changed the title ~~Add Python 3.14 support via ast monkey patch~~ Add Python 3.14 support Mar 18, 2026

rtibbles approved these changes Mar 18, 2026

View reviewed changes

rtibbles merged commit 0fb6085 into learningequality:main Mar 18, 2026
18 checks passed

		@@ -0,0 +1,105 @@
		"""Tests for the ast compatibility monkey patch in conftest.py."""

		@@ -0,0 +1,68 @@
		# Monkey patch to restore deprecated ast node types removed in Python 3.14.

Conversation

rtibblesbot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

References

Reviewer guidance

AI usage

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rtibblesbot commented Mar 17, 2026 •

edited

Loading