[LC-1383] allow profileId routes to accept DID or profileId#1015
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 6d1f2f2 |
✅ Deploy Preview for learncarddocs canceled.
|
Computer8004
had a problem deploying
to
ci-tests
GitHub Actions
Failure
|
To enable Rovo Dev code reviews, link your GitHub account to your Atlassian account. This is a one-time task that takes less than a minute. Once your account is linked, resubmit the pull request to trigger a code review. |
🦋 Changeset detectedLatest commit: 3061bea The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gitstream-cm[bot]](https://avatars.githubusercontent.com/in/230441?s=60&v=4){kind=small}
There was a problem hiding this comment.
✨ PR Review
LGTM
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how
|
Please add a changeset |
|
@TaylorBeeston Changeset added ✅ |
Computer8004
temporarily deployed
to
ci-tests
GitHub Actions
Inactive
TaylorBeeston
had a problem deploying
to
ci-tests
GitHub Actions
Failure
|
@Computer8004 I ran Opencode on this and it found some more routes that you messed. Can you please:
|
|
@Computer8004 (see my earlier comment) |
|
Okay one more time. Please read my last two comments :) |
Computer8004
had a problem deploying
to
ci-tests
GitHub Actions
Failure
|
@TaylorBeeston Added tests for skill-frameworks admin routes (add/remove by did:web, did:key, and error case for unsupported DID format). Regarding the other routes you added in 🐛 Catch more routes (boosts.ts and contracts.ts) - should I add DID resolution tests for those as well, or are the existing test patterns sufficient? |
TaylorBeeston
had a problem deploying
to
ci-tests
GitHub Actions
Failure
TaylorBeeston
had a problem deploying
to
ci-tests
GitHub Actions
Failure
|
Looked through this and I think we're good to go =) @claude do you mind doing a thorough review of this PR? |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
TaylorBeeston
changed the title
TaylorBeeston
had a problem deploying
to
ci-tests
GitHub Actions
Failure
|
🥷 Code experts: TaylorBeeston, Custard7 TaylorBeeston, Custard7 have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
CI secrets are not available to PRs from forks, causing test failures
for external contributors. This change provides a default 64-character
fallback value ('a' * 64) when secrets are not available.
Fixes CI failures on fork PRs like learningeconomy#1015.
CI secrets are not available to PRs from forks, causing test failures
for external contributors. This change provides a default 64-character
fallback value ('a' * 64) when secrets are not available.
Fixes CI failures on fork PRs like learningeconomy#1015.
…alues (#1030) * fix: default SEED and LEARN_CLOUD_SEED for fork PRs CI secrets are not available to PRs from forks, causing test failures for external contributors. This change provides a default 64-character fallback value ('a' * 64) when secrets are not available. Fixes CI failures on fork PRs like #1015. * Update .github/workflows/test.yml --------- Co-authored-by: Computer <computer@agentmail.to> Co-authored-by: Taylor Beeston <39720479+TaylorBeeston@users.noreply.github.com>
TaylorBeeston
temporarily deployed
to
ci-tests
GitHub Actions
Inactive
2 participants
LC-1383
This PR updates 19 routes across the brain service to accept either a profileId OR a DID (did:web or did:key) for the profileId parameter.
Changes
Uses the existing
getProfileIdFromStringhelper to resolve identifiers, enabling more flexible API usage.Routes Updated
profiles.ts:
getOtherProfileconnectWithProfileconnectWithExpiredInvitecancelConnectionRequestconnectWithInvitedisconnectWithacceptConnectionRequestblockProfileunblockProfileboosts.ts:
sendCredentialaddBoostAdminremoveBoostAdmingetOtherBoostPermissionsupdateOtherBoostPermissionssendBoostViaSigningAuthoritycontracts.ts:
verifyContractConsentcredentials.ts:
sendCredentialpresentations.ts:
sendPresentationTesting
Added comprehensive tests for DID resolution in all affected routes, covering:
cc @TaylorBeeston
Closes #1014 (redoing on fresh branch as requested)
✨ PR Description
Purpose: Enhance API flexibility by allowing 19 profile-related routes to accept DID (did:web or did:key) in addition to profileId for improved interoperability across identity systems.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how