Skip to content

chore: expand warning for the verso.code.warnLineLength linter#858

Open
b-mehta wants to merge 1 commit into
leanprover:mainfrom
b-mehta:line-length-linter-message
Open

chore: expand warning for the verso.code.warnLineLength linter#858
b-mehta wants to merge 1 commit into
leanprover:mainfrom
b-mehta:line-length-linter-message

Conversation

@b-mehta
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta commented May 22, 2026

This PR expands the warning message for the verso.code.warnLineLength linter.

The motivation here came from the MI meeting on verso documentation, in which a new Verso user was confused by this message, in two aspects:

  • It is unclear why the line length limit is different in Verso vs in mathlib
  • It is unclear how to turn off this linter or adjust its limit (most linters provide this information)

I attempted to fix both of these issues, and keeping the message consistent with the existing core style. (But I could have gotten this wrong).

@github-actions
Copy link
Copy Markdown
Contributor

Preview for this PR is ready! 🎉

@david-christiansen
Copy link
Copy Markdown
Collaborator

Thanks!

I want to refactor this a bit before merging, but I can take care of that bit.

In particular, the issue is really that wide lines don't render well on narrow viewports (e.g. mobile phones). I'd also like to use our explicit internal API for notes and hints.

I'm getting on a plane soon, so I can't do this immediately, but I'll do it soon.

Thanks again!

@b-mehta
Copy link
Copy Markdown
Contributor Author

b-mehta commented May 22, 2026

Thanks for the quick response! If you have a pointer to the explicit internal API you mention, I'm happy to make that aspect of the change myself (I tried figuring out the internal style but clearly wasn't successful!).

For mobile phones, I agree that's an issue, but does that suggest we should have a similar linter for the blog genre too?

@david-christiansen
Copy link
Copy Markdown
Collaborator

david-christiansen commented May 22, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants