fix: don't error in defeq for missing unification hints - #14733
Open
Rob23oba wants to merge 2 commits into
Open
Conversation
Rob23oba
marked this pull request as ready for review
August 10, 2026 12:27
Collaborator
|
Reference manual CI status:
|
Member
|
This needs a test :) |
Contributor
Author
|
Here you go :-) |
|
Mathlib CI status (docs):
|
Contributor
Author
|
By the way, I would consider this one low priority, since I'm not blocked by this anymore. But I'd also like to mention that it seems to be a larger issue that also affects e.g. public def abc := 3
@[local simp]
theorem abc_eq : abc = 3 := (rfl)
@[expose]
public def hello (x : Fin 3) : Fin abc := by simp -- error: unknown constant `abc_eq`Maybe you can discuss this in the FRO some time though (i.e. what's the right thing to do for environment extensions like this under the module system?) |
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Aug 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of unification hints to not fail with an "unknown constant" error if the unification hint is not available in the current environment. This happens mostly when the unification hint is only imported privately but we are in a public context.
Closes #14734