feat: cbv on arrays using a tree data structure - #14732
Draft
Rob23oba wants to merge 3 commits into
Draft
Conversation
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
wkrozowski
reviewed
Aug 10, 2026
|
|
||
| end ArrayBuilderCtx | ||
|
|
||
| builtin_cbv_simproc ↓ simpPartialToArray (PartialBlock.toArray _) := fun e => do |
Contributor
There was a problem hiding this comment.
Can you achieve this with cbv_opaque annotation?
Contributor
Author
There was a problem hiding this comment.
Does cbv_opaque prevent it from visiting subexpressions?
Contributor
There was a problem hiding this comment.
No, it only prevents from unfolding the function body.
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Aug 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Aug 10, 2026
Contributor
|
!bench |
|
Benchmark results for 11f991c against 87e7204 are in. There are significant results. @wkrozowski
Large changes (1🟥)
Medium changes (1✅)
Small changes (1✅, 11🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds special support for many
Arrayoperations incbvby rewriting them to operations onLean.Sym.PartialBlock, a tree data structure.