feat: lake: support package code quality checks in lake lint - #14716
Open
wkrozowski wants to merge 6 commits into
Open
feat: lake: support package code quality checks in lake lint#14716wkrozowski wants to merge 6 commits into
lake lint#14716wkrozowski wants to merge 6 commits into
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
wkrozowski
marked this pull request as ready for review
August 11, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
lake lint --code-qualityrun the package code quality checks registered with the@[package_code_quality_check]attribute. The checks are discovered in each lint target's import closure and run once per target, and their results are emitted as JSON entries alongside the linter-derived ones. Additional modules providing checks can be supplied with the new--checksCLI option (which implies--code-quality) or the newcheckspackage configuration option; these modules are built and then imported alongside each linted module, so checks can be used without adding them to the package's own imports.Each check runs in
MetaMagainst the lint target's environment and receives the target's name astopLevelModulein itsPackageCheckContext, so it can inspect the elaborated declarations of the module being linted and scope its metrics to it. Checks run concurrently, one task per check; a failing check is reported on stderr and makeslake lintexit nonzero without discarding the results of the other checks.