feat: add support for Nat.log2 in simp and cbv#14047
Open
Rob23oba wants to merge 2 commits into
Open
Conversation
Collaborator
|
Reference manual CI status:
|
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
Nat.log2insimp(through a new simprocNat.reduceLog2) andcbv. However, instead of just relying on the kernel to reduce the definitionNat.log2, we use a specialized lemma to reduce the problemNat.log2 a = bto a (simpler for the kernel) problem2^b <= a < 2^(b+1). This already produces speedups for small numbers that get more significant the larger the number is. For example:(i.e. evaluation by reduction) takes roughly 3 seconds while
now solves the same goal in a few milliseconds. This will especially prove useful for evaluating floating point operations using
cbvsince these useNat.log2frequently.