perf: worst case n log n complexity for Array.qsort#14033
perf: worst case n log n complexity for Array.qsort#14033johanphenkel-cmd wants to merge 8 commits into
Conversation
Implemented ordOfLt Cleaned up and made naming more consistent Added a few explanatory comments
|
!radar |
|
Benchmark results for dadc40e against f0ef737 are in. There are significant results. @TwoFX @johanphenkel-cmd @normalifelias
Large changes (3🟥)
Medium changes (1✅, 2🟥)
Small changes (75✅, 15🟥) Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
|
To catch up you need to at least |
|
!bench |
|
Benchmark results for 0f291d8 against f0ef737 are in. There are significant results. @hargoniX @normalifelias
Large changes (6🟥)
Medium changes (1✅, 5🟥)
Small changes (1✅, 126🟥) Too many entries to display here. View the full report on radar instead. |
|
That is quite the suprising outcome 🙃 |
This PR optimizes Array.qsort to no longer take quadratic time in the worst case.
Fixes #8087