fix: strip @[eval_problem] when it shares a line with the declaration - #543
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hxUxCg6joVz4hMa3m5Zh5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
stripProblemMarkersremove an@[eval_problem]attribute that shares a line with the declaration it marks, rather than only one that occupies the whole line. The stripper split on the first]only when the trimmed line also ended in], so@[eval_problem] theorem foo : ...passed through untouched into the generatedChallenge.lean, whereimport EvalTools.Markershas been stripped, and the build failed withUnknown attribute [eval_problem]. Sibling attributes are preserved in place, so@[eval_problem, simp] theorem foobecomes@[simp] theorem foo.Only multi-hole modules were affected in practice: the target declaration is rewritten from its statement, so its own attribute never reaches the output, but a second marked declaration in the same module is emitted verbatim as context. #191 is currently red for exactly this reason, and #521 carries a commit titled "@[eval_problem] on separate line" working around it by hand.
🤖 Prepared with Claude Code