Skip to content

fix: synchronize standalone generator with LeanEval - #3

Merged
kim-em merged 8 commits into
mainfrom
sync/embedded-core-fixes
Aug 22, 2026
Merged

fix: synchronize standalone generator with LeanEval#3
kim-em merged 8 commits into
mainfrom
sync/embedded-core-fixes

Conversation

@kim-em

@kim-em kim-em commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Synchronize the standalone generator with fixes already merged in LeanEval,
then layer the two small package fixes on top so the complete downstream
contract is tested together.

  • port LeanEval fixes #543, #546, #547, and #550: lexer-aware
    @[eval_problem] removal and block-aware context/open scanning;
  • include active set_option preservation from generator PR Preserve active options around extracted syntax context #1;
  • include quoted Lean-name path handling from generator PR Fix quoted Lean module path resolution #2;
  • reject inline scoped context commands without reverting the newer block
    scanner; and
  • use explicit generator schema-version terminology without changing the
    frozen request/response contract.

PRs #1 and #2 remain the small independently reviewable changes. After they
merge, this branch will be synchronized with main so this PR contains only
the LeanEval-to-standalone synchronization.

Current verification

Final combined head: d04b83e63e41f5a08076c569943326f793529333.

  • standalone lake build and hosted generator CI pass;
  • generator contract, module-path executable, context, Python byte-compilation,
    actionlint, and diff checks pass;
  • theorem-hole and definition-hole workspaces remain byte-identical across all
    10 generated files in each fixture;
  • downstream LeanEval consumer PR #553 is green across repository checks,
    security/scoring smoke, all eight catalog shards, manifest aggregation, and
    artifact verification at 1ed9b188d7a1c58c51fb06af204429c5acadd3d9;
  • the combined downstream corpus builds at the reviewed pins; and
  • Formal Conjectures PR #4951 imports, verifies, generates, and compiles all
    FC100 declarations with its hosted audit green at
    2654e42de2026de6cdb248ad5ed0f1c7d659c8fa.

Independent review of PRs #1, #2, and this synchronization remains required
before the generator pin and LeanEval consumer are advanced.

kim-em added 4 commits August 22, 2026 03:12
Port the lexer-aware marker stripping and context-command parsing fixes already merged in LeanEval (#543, #546, #547, and #550) into the standalone generator core.
@kim-em
kim-em requested review from Kha and leodemoura August 22, 2026 03:15
@kim-em

kim-em commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator Author

Downstream verification against exact head 62b38001bff98e4110081261ae7c466183204b60: LeanEval builds the generator consumer targets cleanly; the full generator regression suite passes 136/136, module-coverage suite 19/19, and the compatibility-marker environment regression now passes. The all-problem generated-catalog check is still traversing the 128-problem corpus; I will post its final result separately.

@kim-em

kim-em commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator Author

Terminology-only follow-up d04b83e reserves bare v1/v2 for LeanEval problem sets: prose now says generator schema version 1, while frozen filenames such as request-v1.schema.json remain unchanged. Runtime generator behavior and emitted file bytes are unchanged; package CI is green. The downstream 128-problem check is running against prior head 62b3800, whose executable source is byte-identical apart from this documentation/comment/schema-title update.

@kim-em

kim-em commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator Author

Additional full-corpus consumer evidence: the standalone generator completed an unsharded traversal of the LeanEval corpus. It correctly exposed 34 stale Annals workspaces whose committed outputs predated preservation of set_option autoImplicit false; the consumer PR has now mechanically regenerated those outputs in lean-eval#553 commit 1ed9b18. Per-problem generate --check then passed for all 50 Annals workspaces. This is consistent with the option-preservation coverage in this repository; no additional generator defect was found.

# Conflicts:
#	LeanEvalGenerator/Core/Generate.lean
#	tests/Context.lean
#	tests/scripts/contract.py
@kim-em
kim-em merged commit 77373a5 into main Aug 22, 2026
1 check passed
@kim-em
kim-em deleted the sync/embedded-core-fixes branch August 22, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant