[Merged by Bors] - chore(RingTheory/Derivation/Basic): generalize Derivation.compAlgebraMap to semirings - #8151
Closed
eric-wieser wants to merge 4 commits into
Closed
[Merged by Bors] - chore(RingTheory/Derivation/Basic): generalize Derivation.compAlgebraMap to semirings#8151eric-wieser wants to merge 4 commits into
Derivation.compAlgebraMap to semirings#8151eric-wieser wants to merge 4 commits into
Conversation
…aMap` to semirings
riccardobrasca
approved these changes
Nov 3, 2023
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
the
delegated
eric-wieser
added
the
awaiting-CI
Member
|
BTW, where is now "Note [custom simps projection]"? There is no hyperlink in the doc. |
Member
Author
|
Library notes are not yet implemented in doc-gen4 (or vscode) :( |
github-actions
Bot
removed
the
awaiting-CI
Member
Author
|
bors merge |
bors Bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
…aMap` to semirings (#8151) Also adds a `simps` configuration so we get nice lemmas names with `@[simps]` and shuffles the variable order to put all the types first
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors Bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
…aMap` to semirings (#8151) Also adds a `simps` configuration so we get nice lemmas names with `@[simps]` and shuffles the variable order to put all the types first
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
Bot
changed the title
Derivation.compAlgebraMap to semiringsDerivation.compAlgebraMap to semirings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a
simpsconfiguration so we get nice lemmas names with@[simps]and shuffles the variable order to put all the types first