Skip to content

[Merged by Bors] - chore(AlgebraicTopology/SimplexCategory): delete synthesizable instances - #42222

Closed
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:simplex_category_no_fintype
Closed

[Merged by Bors] - chore(AlgebraicTopology/SimplexCategory): delete synthesizable instances#42222
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:simplex_category_no_fintype

Conversation

@YaelDillies

Copy link
Copy Markdown
Contributor

inferInstance works in place of inferInstanceAs in both places.

Zulip


Open in Gitpod

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

PR summary 9a5fd66c3b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- instance (x : SimplexCategory) (n : ℕ) : OfNat (ToType x) n
- instance (x : SimplexCategory) : Fintype (ToType x)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 9a5fd66).

  • +0 new declarations
  • −2 removed declarations
-SimplexCategory.instFintypeToTypeOrderHomFinHAddNatLenOfNat
-SimplexCategory.instOfNatToTypeOrderHomFinHAddNatLenOfNat

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 9a5fd66c3b
Reference commit 12ab8e82f8

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebraic-topology Algebraic topology label Jul 29, 2026
@YaelDillies
YaelDillies requested a review from joelriou July 29, 2026 06:32
@robin-carlier

Copy link
Copy Markdown
Contributor

Thanks!
maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 29, 2026
@joelriou

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 29, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 29, 2026
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 29, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(AlgebraicTopology/SimplexCategory): delete synthesizable instances [Merged by Bors] - chore(AlgebraicTopology/SimplexCategory): delete synthesizable instances Jul 29, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 29, 2026
@YaelDillies
YaelDillies deleted the simplex_category_no_fintype branch July 29, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-algebraic-topology Algebraic topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants