Skip to content

feat: add NumberField.Units.finrank_eq#40239

Open
riccardobrasca wants to merge 1 commit into
leanprover-community:masterfrom
riccardobrasca:NumberField_Units_finrank_eq
Open

feat: add NumberField.Units.finrank_eq#40239
riccardobrasca wants to merge 1 commit into
leanprover-community:masterfrom
riccardobrasca:NumberField_Units_finrank_eq

Conversation

@riccardobrasca
Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca commented Jun 4, 2026

From flt-regular.


Open in Gitpod

@riccardobrasca riccardobrasca requested a review from xroblot June 4, 2026 19:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 8a18e788f0

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.NumberField.Units.DirichletTheorem 3087 3088 +1 (+0.03%)
Import changes for all files
Files Import difference
9 files Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CMField Mathlib.NumberTheory.NumberField.CanonicalEmbedding.FundamentalCone Mathlib.NumberTheory.NumberField.CanonicalEmbedding.NormLeOne Mathlib.NumberTheory.NumberField.Cyclotomic.Three Mathlib.NumberTheory.NumberField.DedekindZeta Mathlib.NumberTheory.NumberField.Ideal.Asymptotics Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.NumberField.Units.Regulator
1

Declarations diff (regex)

+ finrank_eq

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 8a18e78).

  • +1 new declarations
  • −0 removed declarations
+NumberField.Units.finrank_eq

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 8a18e788f0
Reference commit 5135da2b75

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jun 4, 2026
@riccardobrasca riccardobrasca temporarily deployed to cache-upload-forks June 4, 2026 19:37 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant