Skip to content

fix: label parsing in the check_title workflow#40234

Open
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:checktitle-fix-label-parsing
Open

fix: label parsing in the check_title workflow#40234
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:checktitle-fix-label-parsing

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jun 4, 2026

The workflow step returns all labels as one string, separated by newlines. Since GitHub labels are allowed to contain spaces, it's safest to make the script expect a newline-separated (and not e.g. space-separated) label names.

The old logic never fired, as the labels are a flag, not a variable argument.

Spotted in #40181; thanks @kim-em for the report and suggesting an initial fix.


Open in Gitpod

The workflow step returns all labels as one string, separated by newlines.
Since GitHub labels are allowed to contain spaces, it's safest to make
the script expect a newline-separated (and not e.g. space-separated) label
names.

The old logic never fired, as the labels are a flag, not a variable argument.
@grunweg grunweg requested a review from bryangingechen June 4, 2026 16:58
@grunweg grunweg added the CI Modifies the continuous integration setup or other automation label Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 285ee03ca0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 285ee03).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 285ee03ca0
Reference commit c87658adb9

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant