fix: label parsing in the check_title workflow#40234
Open
grunweg wants to merge 1 commit into
Open
Conversation
The workflow step returns all labels as one string, separated by newlines. Since GitHub labels are allowed to contain spaces, it's safest to make the script expect a newline-separated (and not e.g. space-separated) label names. The old logic never fired, as the labels are a flag, not a variable argument.
2 tasks
PR summary 285ee03ca0Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow step returns all labels as one string, separated by newlines. Since GitHub labels are allowed to contain spaces, it's safest to make the script expect a newline-separated (and not e.g. space-separated) label names.
The old logic never fired, as the labels are a flag, not a variable argument.
Spotted in #40181; thanks
@kim-emfor the report and suggesting an initial fix.