Skip to content

feat(Tactic/Group): strengthen the group tactic and add tests#40224

Open
AlexBrodbelt wants to merge 1 commit into
leanprover-community:masterfrom
AlexBrodbelt:AlexBrodbelt/Mathlib/Tactic/Group
Open

feat(Tactic/Group): strengthen the group tactic and add tests#40224
AlexBrodbelt wants to merge 1 commit into
leanprover-community:masterfrom
AlexBrodbelt:AlexBrodbelt/Mathlib/Tactic/Group

Conversation

@AlexBrodbelt
Copy link
Copy Markdown
Collaborator

@AlexBrodbelt AlexBrodbelt commented Jun 4, 2026

The group tactic is improved to:

Once simplification on the exponents is done, apply left and right cancellation. That is, to normalise expressions like a * b = a * c to b * c.

Apply a post-processing where expression of the form ( · )^(-1) are normalised to use the inversion notation ( · )⁻¹. This allows immediately using lemmas involving inversion which is how most lemmas are stated.


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary a2f58acf35

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit a2f58acf35
Reference commit 0531bb79fe

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Jun 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@AlexBrodbelt AlexBrodbelt changed the title feat(Mathlib/Tactic/Group): strengthen the group tactic and add tests feat(Tactic/Group): strengthen the group tactic and add tests Jun 4, 2026
@AlexBrodbelt AlexBrodbelt added the WIP Work in progress label Jun 4, 2026
@AlexBrodbelt AlexBrodbelt temporarily deployed to cache-upload-forks June 4, 2026 14:41 — with GitHub Actions Inactive
@AlexBrodbelt AlexBrodbelt changed the title feat(Tactic/Group): strengthen the group tactic and add tests feat(Tactic/Group): strengthen the group tactic and add tests Jun 4, 2026
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jun 4, 2026

Once your PR is complete, I'm very curious to see if there is any performance effect. But that can wait for later. Until then, I'm just excited about your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-meta Tactics, attributes or user commands WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants