Skip to content

chore: replace (by exact occurences#40223

Draft
felixpernegger wants to merge 4 commits into
leanprover-community:masterfrom
felixpernegger:byexact
Draft

chore: replace (by exact occurences#40223
felixpernegger wants to merge 4 commits into
leanprover-community:masterfrom
felixpernegger:byexact

Conversation

@felixpernegger
Copy link
Copy Markdown
Contributor

@felixpernegger felixpernegger commented Jun 4, 2026

Replace (by exact abc with (abc whenever it works


Open in Gitpod

@felixpernegger felixpernegger marked this pull request as draft June 4, 2026 14:14
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Jun 4, 2026

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

PR summary 4a0156f842

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4a0156f842
Reference commit 8ec10e9bfb

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger felixpernegger temporarily deployed to cache-upload-forks June 4, 2026 14:47 — with GitHub Actions Inactive
@felixpernegger felixpernegger changed the title chore: replace by exact occurences chore: replace (by exact occurences Jun 4, 2026
@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 4, 2026
@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Jun 4, 2026

This is a nice idea! Let me quickly add that with the module system, some uses of by exact are necessary (that weren't in previous versions of Lean 4), and that by exact can sometimes change the elaboration order in helpful ways. So some of the by exact will be necessary. This isn't to discourage your PR, just to explain why some things might be happening!

@felixpernegger felixpernegger temporarily deployed to cache-upload-forks June 4, 2026 20:21 — with GitHub Actions Inactive
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 4, 2026
@felixpernegger felixpernegger temporarily deployed to cache-upload-forks June 5, 2026 02:03 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants