chore: reduce imports#40222
Conversation
|
!bench |
|
Benchmark results for 4bdcb37 against 07107e4 are in. There are significant results. @JovanGerb
Large changes (3✅)
and 1 hidden Medium changes (16✅)
Small changes (2419✅) Too many entries to display here. View the full report on radar instead. |
PR summary 359770281c
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.NormNum.Core | 199 | 200 | +1 (+0.50%) |
| Mathlib.Tactic.Common | 248 | 249 | +1 (+0.40%) |
Import changes for all files
| Files | Import difference |
|---|---|
| ../mathlib-ci/scripts/pr_summary/import_trans_difference.sh all | |
| There are 7155 files with changed transitive imports taking up over 320608 characters: this is too many to display! | |
You can run this locally from your mathlib4 directory: |
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
Declarations diff (regex)
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean -- pending)
Computed after the build finishes.
No changes to strong technical debt.
No changes to weak technical debt.
Current commit 359770281c
Reference commit 07107e4cfd
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
!bench |
|
Benchmark results for 1640267 against 07107e4 are in. There are significant results. @JovanGerb
Large changes (3✅)
and 1 hidden Medium changes (16✅)
Small changes (2433✅) Too many entries to display here. View the full report on radar instead. |
|
!bench |
|
Benchmark results for 3597702 against 07107e4 are in. There are significant results. @JovanGerb
Large changes (3✅)
and 1 hidden Medium changes (16✅)
Small changes (1775✅) Too many entries to display here. View the full report on radar instead. |
|
Ok, yes, with importing Plausible the result is a lot worse! |
This is a test to see how much imports can be reduced.